From: Scirlat Danut <danut.scirlat@gmail.com>
Date: Fri, 9 Feb 2024 21:39:42 +0000 (+0200)
Subject: Remove mypy skip flags (#2497)
X-Git-Tag: 0.37.1~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f724827795152dc37204ebc99d96f11a092404b4;p=thirdparty%2Fstarlette.git

Remove mypy skip flags (#2497)

* Remove flags

* Apply suggestions from code review

* Remove mypy overrides

---------

Co-authored-by: Scirlat Danut <scirlatdanut@scirlats-mini.lan>
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
---

diff --git a/pyproject.toml b/pyproject.toml
index 48562e71..3cf7c0d4 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -66,14 +66,6 @@ python_version = "3.8"
 module = "starlette.testclient.*"
 implicit_optional = true
 
-# TODO: Uncomment the following configuration when
-# https://github.com/python/mypy/issues/10045 is solved. In the meantime,
-# we are calling `mypy tests` directly. Check `scripts/check` for more info.
-# [[tool.mypy.overrides]]
-# module = "tests.*"
-# disallow_untyped_defs = false
-# check_untyped_defs = true
-
 [tool.pytest.ini_options]
 addopts = "-rxXs --strict-config --strict-markers"
 xfail_strict = true
diff --git a/scripts/check b/scripts/check
index 7f169e3b..3e8f0578 100755
--- a/scripts/check
+++ b/scripts/check
@@ -12,6 +12,5 @@ set -x
 ${PREFIX}ruff format --check --diff $SOURCE_FILES
 # TODO: Use `[[tool.mypy.overrides]]` on the `pyproject.toml` when the mypy issue is solved:
 # github.com/python/mypy/issues/10045. Check github.com/encode/starlette/pull/2180 for more info.
-${PREFIX}mypy starlette
-${PREFIX}mypy tests --disable-error-code no-untyped-def --disable-error-code no-untyped-call
+${PREFIX}mypy $SOURCE_FILES
 ${PREFIX}ruff check $SOURCE_FILES