From: Daniel Stenberg <daniel@haxx.se>
Date: Wed, 5 Jun 2024 06:31:11 +0000 (+0200)
Subject: cfilters: make Curl_conn_connect always assign 'done'
X-Git-Tag: curl-8_9_0~294
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f75aa2857f7fedb9650cf7bf0738b8225f262e30;p=thirdparty%2Fcurl.git

cfilters: make Curl_conn_connect always assign 'done'

It could return error without assigning it, and we have a caller in
multi.c that assumes it gets set.

Spotted by CodeSonar
Closes #13884
---

diff --git a/lib/cfilters.c b/lib/cfilters.c
index a1e405bc5e..60767aa389 100644
--- a/lib/cfilters.c
+++ b/lib/cfilters.c
@@ -345,8 +345,10 @@ CURLcode Curl_conn_connect(struct Curl_easy *data,
 
   cf = data->conn->cfilter[sockindex];
   DEBUGASSERT(cf);
-  if(!cf)
+  if(!cf) {
+    *done = FALSE;
     return CURLE_FAILED_INIT;
+  }
 
   *done = cf->connected;
   if(!*done) {