From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 7 Jun 2022 06:49:25 +0000 (+0300)
Subject: vdpa/mlx5: fix error code for deleting vlan
X-Git-Tag: v5.19-rc2~8^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f766c409fcb33cfd0f511e8251831520e089eb89;p=thirdparty%2Fkernel%2Flinux.git

vdpa/mlx5: fix error code for deleting vlan

Return success if we were able to delete a vlan.  The current code
always returns failure.

Fixes: baf2ad3f6a98 ("vdpa/mlx5: Add RX MAC VLAN filter support")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Message-Id: <Yp709f1g9NcMBCHg@kili>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: Eli Cohen <elic@nvidia.com>
Acked-by: Si-Wei Liu <si-wei.liu@oracle.com>
---

diff --git a/drivers/vdpa/mlx5/net/mlx5_vnet.c b/drivers/vdpa/mlx5/net/mlx5_vnet.c
index b878c10955308..51fb15c35e426 100644
--- a/drivers/vdpa/mlx5/net/mlx5_vnet.c
+++ b/drivers/vdpa/mlx5/net/mlx5_vnet.c
@@ -1814,6 +1814,7 @@ static virtio_net_ctrl_ack handle_ctrl_vlan(struct mlx5_vdpa_dev *mvdev, u8 cmd)
 
 		id = mlx5vdpa16_to_cpu(mvdev, vlan);
 		mac_vlan_del(ndev, ndev->config.mac, id, true);
+		status = VIRTIO_NET_OK;
 		break;
 	default:
 	break;