From: Ramsay Jones Date: Thu, 18 Jul 2024 01:12:19 +0000 (+0100) Subject: Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS X-Git-Tag: v2.47.0-rc0~175^2~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f78e2dd88a366875acb40352c80283929ebd8ab4;p=thirdparty%2Fgit.git Makefile: drop -Wno-universal-initializer from SP_EXTRA_FLAGS Commit 1c96642326 ("sparse: allow '{ 0 }' to be used without warnings", 2020-05-22) added -Wno-universal-initializer to the SP_EXTRA_FLAGS in order to suppress potential sparse warnings from using '{0}' as an aggregate initializer. At that time, the default was for sparse to issue warnings (i.e. the default was -Wuniversal-initializer) if such an initializer was used to initialize an aggregate whose first member was a pointer type. However, this default was changed just a few days later to -Wno-universal-initializer (first released in sparse v0.6.2) and has been so in all subsequent release versions of sparse. Thus, including -Wno-universal-initializer in the SP_EXTRA_FLAGS variable is redundant. Remove the unnecessary warning flag from SP_EXTRA_FLAGS, essentially reverting commit 1c96642326. Signed-off-by: Ramsay Jones Signed-off-by: Junio C Hamano --- diff --git a/Makefile b/Makefile index d6479092a0..ce3ff2476c 100644 --- a/Makefile +++ b/Makefile @@ -1376,7 +1376,7 @@ PTHREAD_CFLAGS = # For the 'sparse' target SPARSE_FLAGS ?= -std=gnu99 -SP_EXTRA_FLAGS = -Wno-universal-initializer +SP_EXTRA_FLAGS = # For informing GIT-BUILD-OPTIONS of the SANITIZE=leak,address targets SANITIZE_LEAK =