From: Michael Tremer <michael.tremer@ipfire.org>
Date: Thu, 27 Jul 2023 13:54:48 +0000 (+0000)
Subject: pakfire: Fix integer overflow in bit fields
X-Git-Tag: 0.9.29~82
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f791b2f60a41a17157e1061cdb4a41001077fcfa;p=pakfire.git

pakfire: Fix integer overflow in bit fields

Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
---

diff --git a/src/libpakfire/pakfire.c b/src/libpakfire/pakfire.c
index 0544d756b..ac3ba0961 100644
--- a/src/libpakfire/pakfire.c
+++ b/src/libpakfire/pakfire.c
@@ -126,9 +126,9 @@ struct pakfire {
 	magic_t magic;
 
 	// States
-	int destroy_on_free:1;
-	int pool_ready:1;
-	int in_free:1;
+	unsigned int destroy_on_free:1;
+	unsigned int pool_ready:1;
+	unsigned int in_free:1;
 };
 
 /*
@@ -382,9 +382,11 @@ static void pakfire_free(struct pakfire* pakfire) {
 	int r;
 
 	// Avoid recursive free
-	if (pakfire->in_free++)
+	if (pakfire->in_free)
 		return;
 
+	pakfire->in_free = 1;
+
 	// Destroy the commandline repository
 	repo = pakfire_get_repo(pakfire, PAKFIRE_REPO_COMMANDLINE);
 	if (repo) {