From: Willy Tarreau <w@1wt.eu>
Date: Fri, 11 Dec 2020 10:11:06 +0000 (+0100)
Subject: MINOR: checks: don't call conn_cond_update_polling() anymore
X-Git-Tag: v2.4-dev3~26
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f7e4a6fc078a2eaf956340765e1db16ecfb29e1e;p=thirdparty%2Fhaproxy.git

MINOR: checks: don't call conn_cond_update_polling() anymore

This was a leftover of the pre-mux v1.8-dev3 era. It makes no sense anymore
to try to disable polling on a connection we don't own, it's the mux's job
and it's properly done upon shutdowns and closes.
---

diff --git a/src/check.c b/src/check.c
index c625b90437..51ae99ebfc 100644
--- a/src/check.c
+++ b/src/check.c
@@ -812,12 +812,6 @@ static int wake_srv_chk(struct conn_stream *cs)
 	else
 		HA_SPIN_UNLOCK(EMAIL_ALERTS_LOCK, &q->lock);
 
-	/* if a connection got replaced, we must absolutely prevent the connection
-	 * handler from touching its fd, and perform the FD polling updates ourselves
-	 */
-	if (ret < 0)
-		conn_cond_update_polling(conn);
-
 	return ret;
 }