From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Mon, 18 Aug 2025 12:30:14 +0000 (+0300)
Subject: regulator: rt5133: Fix IS_ERR() vs NULL bug in rt5133_validate_vendor_info()
X-Git-Tag: v6.18-rc1~166^2~12
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f7f804633c91f0fbf03eefbae39eec2205191a82;p=thirdparty%2Flinux.git

regulator: rt5133: Fix IS_ERR() vs NULL bug in rt5133_validate_vendor_info()

The "priv->cdata" pointer isn't an error pointer; this should be a NULL
check instead.  Otherwise it leads to a NULL pointer dereference in the
caller, rt5133_probe().

Fixes: 714165e1c4b0 ("regulator: rt5133: Add RT5133 PMIC regulator Support")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/aKMc1oK-7yY4cD3K@stanley.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
---

diff --git a/drivers/regulator/rt5133-regulator.c b/drivers/regulator/rt5133-regulator.c
index 39532618e73d4..129b1f13c8802 100644
--- a/drivers/regulator/rt5133-regulator.c
+++ b/drivers/regulator/rt5133-regulator.c
@@ -510,7 +510,7 @@ static int rt5133_validate_vendor_info(struct rt5133_priv *priv)
 			break;
 		}
 	}
-	if (IS_ERR(priv->cdata)) {
+	if (!priv->cdata) {
 		dev_err(priv->dev, "Failed to find regulator match version\n");
 		return -ENODEV;
 	}