From: Hans de Goede Date: Thu, 4 Feb 2021 11:38:48 +0000 (+0100) Subject: platform/surface: surface3-wmi: Fix variable 'status' set but not used compiler warning X-Git-Tag: v5.12-rc1~123^2~11 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f807f4b7b32db00fc8622289644362e0695989bb;p=thirdparty%2Flinux.git platform/surface: surface3-wmi: Fix variable 'status' set but not used compiler warning Explicitly check the status rather then relying on output.pointer staying NULL on an error. This silences the following compiler warning: drivers/platform/surface/surface3-wmi.c:60:14: warning: variable 'status' set but not used [-Wunused-but-set-variable] Reported-by: kernel test robot Reviewed-by: Maximilian Luz Signed-off-by: Hans de Goede Link: https://lore.kernel.org/r/20210204113848.105994-1-hdegoede@redhat.com --- diff --git a/drivers/platform/surface/surface3-wmi.c b/drivers/platform/surface/surface3-wmi.c index 130b6f52a6001..fcd1d4fb94d50 100644 --- a/drivers/platform/surface/surface3-wmi.c +++ b/drivers/platform/surface/surface3-wmi.c @@ -57,12 +57,16 @@ static DEFINE_MUTEX(s3_wmi_lock); static int s3_wmi_query_block(const char *guid, int instance, int *ret) { struct acpi_buffer output = { ACPI_ALLOCATE_BUFFER, NULL }; + union acpi_object *obj = NULL; acpi_status status; - union acpi_object *obj; int error = 0; mutex_lock(&s3_wmi_lock); status = wmi_query_block(guid, instance, &output); + if (ACPI_FAILURE(status)) { + error = -EIO; + goto out_free_unlock; + } obj = output.pointer;