From: Peter Krempa <pkrempa@redhat.com>
Date: Tue, 9 Sep 2025 13:43:52 +0000 (+0200)
Subject: qemuMigrationSrcIsSafeDisk: Check also data file properties for migrability
X-Git-Tag: v11.8.0-rc1~21
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f8201b0032b1d53f4839cf58f3e113ae1bb3fbce;p=thirdparty%2Flibvirt.git

qemuMigrationSrcIsSafeDisk: Check also data file properties for migrability

If the qcow2 data file feature (which separates the data into a separate
file from the metadata) is in use the migration safety check ought to
consider both the metadata and the data file for safe migration.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
---

diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index ae26f74f8c..2e52e73f48 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -1795,6 +1795,12 @@ qemuMigrationSrcIsSafeDisk(virDomainDiskDef *disk,
                                                  &requires_safe_cache) < 0)
         return false;
 
+    if (disk->src->dataFileStore &&
+        qemuMigrationSrcCheckStorageSourceSafety(disk->src->dataFileStore,
+                                                 cfg, &unsafe_storage,
+                                                 &requires_safe_cache) < 0)
+        return false;
+
     if (unsafe_storage) {
         virReportError(VIR_ERR_MIGRATE_UNSAFE, "%s",
                        _("Migration without shared storage is unsafe"));