From: Kent Overstreet Date: Thu, 17 Mar 2022 00:31:15 +0000 (-0400) Subject: bcachefs: Convert some WARN_ONs to WARN_ON_ONCE X-Git-Tag: v6.7-rc1~201^2~1054 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f8494d253534d3c49e80a483b74469bbeb01367f;p=thirdparty%2Fkernel%2Flinux.git bcachefs: Convert some WARN_ONs to WARN_ON_ONCE These warnings are symptomatic of something else going wrong, we don't want them spamming up the logs as that'll make it harder to find the real issue. Signed-off-by: Kent Overstreet --- diff --git a/fs/bcachefs/fs-io.c b/fs/bcachefs/fs-io.c index 77a893260fd8b..14550ac610c65 100644 --- a/fs/bcachefs/fs-io.c +++ b/fs/bcachefs/fs-io.c @@ -1247,7 +1247,7 @@ static void bch2_writepage_io_done(struct bch_write_op *op) * racing with fallocate can cause us to add fewer sectors than * expected - but we shouldn't add more sectors than expected: */ - WARN_ON(io->op.i_sectors_delta > 0); + WARN_ON_ONCE(io->op.i_sectors_delta > 0); /* * (error (due to going RO) halfway through a page can screw that up @@ -1434,8 +1434,8 @@ do_io: sectors << 9, offset << 9)); /* Check for writing past i_size: */ - WARN_ON((bio_end_sector(&w->io->op.wbio.bio) << 9) > - round_up(i_size, block_bytes(c))); + WARN_ON_ONCE((bio_end_sector(&w->io->op.wbio.bio) << 9) > + round_up(i_size, block_bytes(c))); w->io->op.res.sectors += reserved_sectors; w->io->op.i_sectors_delta -= dirty_sectors;