From: Willy Tarreau <w@1wt.eu>
Date: Fri, 28 Mar 2008 17:09:38 +0000 (+0100)
Subject: [BUG] fix double-decrement of server connections
X-Git-Tag: v1.3.15~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f899b94e6341a0e0b1b0e03f56c2f0a326174c26;p=thirdparty%2Fhaproxy.git

[BUG] fix double-decrement of server connections

If a client does a sudden dirty close (CL_STCLOSE) during a server
connect turn-around, then the number of server connections is
decremented twice. This causes huge problems on the affected
server because when its connection number becomes negative, it
overflows and prevents the server from accepting new connections
due to an apparent saturation.

The fix consists in not decrementing the counter if the server is
in a turn-around state.
---

diff --git a/src/proto_http.c b/src/proto_http.c
index ba79c2b6c3..3f8e0ac88d 100644
--- a/src/proto_http.c
+++ b/src/proto_http.c
@@ -2568,11 +2568,14 @@ int process_srv(struct session *t)
 		     ((t->req->l == 0 && !(req->flags & BF_WRITE_STATUS)) ||
 		      t->be->options & PR_O_ABRT_CLOSE))) { /* give up */
 			tv_eternity(&req->cex);
-			fd_delete(t->srv_fd);
-			if (t->srv) {
-				t->srv->cur_sess--;
-				if (t->srv->proxy->lbprm.server_drop_conn)
-					t->srv->proxy->lbprm.server_drop_conn(t->srv);
+			if (!(t->flags & SN_CONN_TAR)) {
+				/* if we are in turn-around, we have already closed the FD */
+				fd_delete(t->srv_fd);
+				if (t->srv) {
+					t->srv->cur_sess--;
+					if (t->srv->proxy->lbprm.server_drop_conn)
+						t->srv->proxy->lbprm.server_drop_conn(t->srv);
+				}
 			}
 
 			/* note that this must not return any error because it would be able to