From: Guinevere Larsen <guinevere@redhat.com>
Date: Tue, 28 Jan 2025 19:09:51 +0000 (-0300)
Subject: gdb: restrict configure error with all targets and 64 bit bfd to mips
X-Git-Tag: binutils-2_45~1678
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f8baffc3c0852eeffc63481ab2d1f9f9f70902ef;p=thirdparty%2Fbinutils-gdb.git

gdb: restrict configure error with all targets and 64 bit bfd to mips

The recent commit b601c58034ed755fb765fc13782b6876bffd25d4 causes the
gdb configure to fail if --enable-targets=all was requested, but 64 bit
bfd was not enabled. This was due to a build failure first reported
against mips, and that I also encountered building on a 32 bit mips
system, but that looked like a general failure.

Further examination showed that this is, in fact, mips-specific (or at
least, not completely generic) as other targets like debian-i386 and
32-bit arm could build all targets just fine.

This commit restricts the new error to only trigger in mips hosts.

Approved-By: Andrew Burgess <aburgess@redhat.com>
---

diff --git a/gdb/configure b/gdb/configure
index cfb4f446ef8..bdc405e01b3 100755
--- a/gdb/configure
+++ b/gdb/configure
@@ -25005,9 +25005,16 @@ if test x${all_targets} = xtrue; then
   if test x${enable_64_bit_bfd} = xyes; then
     TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)'
   else
-    # If all targets were requested, but 64 bit bfd is not enabled,
-    # the build will fail. See PR 28684.
-    as_fn_error $? "--enable-targets=all requires --enable-64-bit-bfd" "$LINENO" 5
+    case ${host} in
+    mips*)
+      # If all targets were requested, but 64 bit bfd is not enabled,
+      # the build will fail. See PR 28684.
+      as_fn_error $? "--enable-targets=all requires --enable-64-bit-bfd" "$LINENO" 5
+      ;;
+    *)
+      TARGET_OBS='$(ALL_TARGET_OBS)'
+      ;;
+    esac
   fi
 fi
 
diff --git a/gdb/configure.ac b/gdb/configure.ac
index 77f774e23ee..fb77e79e73b 100644
--- a/gdb/configure.ac
+++ b/gdb/configure.ac
@@ -257,9 +257,16 @@ if test x${all_targets} = xtrue; then
   if test x${enable_64_bit_bfd} = xyes; then
     TARGET_OBS='$(ALL_TARGET_OBS) $(ALL_64_TARGET_OBS)'
   else
-    # If all targets were requested, but 64 bit bfd is not enabled,
-    # the build will fail. See PR 28684.
-    AC_MSG_ERROR([--enable-targets=all requires --enable-64-bit-bfd])
+    case ${host} in
+    mips*)
+      # If all targets were requested, but 64 bit bfd is not enabled,
+      # the build will fail. See PR 28684.
+      AC_MSG_ERROR([--enable-targets=all requires --enable-64-bit-bfd])
+      ;;
+    *)
+      TARGET_OBS='$(ALL_TARGET_OBS)'
+      ;;
+    esac
   fi
 fi