From: Lucas De Marchi Date: Mon, 20 Jan 2020 19:15:38 +0000 (-0300) Subject: libkmod: reset was_space on second pass X-Git-Tag: v27~1 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f975f6bfcc88ce8cb653efa580ea73a8c22e17df;p=thirdparty%2Fkmod.git libkmod: reset was_space on second pass The softdep config parser uses a 2-pass approach to use a single allocation for all the softdep struct. However "was_space" variable isn't reset between them. This can lead to a buffer overflow. Reported-by: Jorge Lucangeli Obes Link: https://lore.kernel.org/linux-modules/CAKYuF5QhGCPCazHQjN-=kFc5kHs7Ok8WqmmGLo31CiOEN8TYdA@mail.gmail.com --- diff --git a/libkmod/libkmod-config.c b/libkmod/libkmod-config.c index aaac0a13..7b623677 100644 --- a/libkmod/libkmod-config.c +++ b/libkmod/libkmod-config.c @@ -335,6 +335,7 @@ static int kmod_config_add_softdep(struct kmod_config *config, n_pre = 0; n_post = 0; mode = S_NONE; + was_space = false; for (p = s = line; ; s++) { size_t plen;