From: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Date: Wed, 16 Jun 2021 09:34:32 +0000 (+0300)
Subject: Fix outdated comment that talked about seek position of WAL file.
X-Git-Tag: REL_12_8~101
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f98635ad6295ad142779756e60325a8e7f825909;p=thirdparty%2Fpostgresql.git

Fix outdated comment that talked about seek position of WAL file.

Since commit c24dcd0cfd, we have been using pg_pread() to read the WAL
file, which doesn't change the seek position (unless we fall back to
the implementation in src/port/pread.c). Update comment accordingly.

Backpatch-through: 12, where we started to use pg_pread()
---

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index e52e805708b..67dcd1e126d 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -785,11 +785,9 @@ static XLogSegNo openLogSegNo = 0;
 
 /*
  * These variables are used similarly to the ones above, but for reading
- * the XLOG.  Note, however, that readOff generally represents the offset
- * of the page just read, not the seek position of the FD itself, which
- * will be just past that page. readLen indicates how much of the current
- * page has been read into readBuf, and readSource indicates where we got
- * the currently open file from.
+ * the XLOG.  readOff is the offset of the page just read, readLen
+ * indicates how much of it has been read into readBuf, and readSource
+ * indicates where we got the currently open file from.
  */
 static int	readFile = -1;
 static XLogSegNo readSegNo = 0;