From: Volker Lendecke <vl@samba.org>
Date: Mon, 5 May 2025 12:02:39 +0000 (+0200)
Subject: libsmb: Remove a redundant tevent_req_nterror()
X-Git-Tag: tevent-0.17.0~191
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=f9e0d008d6ebac9388c28a00df7963ff0418dc39;p=thirdparty%2Fsamba.git

libsmb: Remove a redundant tevent_req_nterror()

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>
---

diff --git a/source3/libsmb/cli_smb2_fnum.c b/source3/libsmb/cli_smb2_fnum.c
index 06599004f39..f09e97a92e9 100644
--- a/source3/libsmb/cli_smb2_fnum.c
+++ b/source3/libsmb/cli_smb2_fnum.c
@@ -1556,7 +1556,6 @@ struct tevent_req *cli_smb2_list_send(
 		status = smb2_create_blob_add(in_cblobs, in_cblobs,
 					      SMB2_CREATE_TAG_POSIX, blob);
 		if (tevent_req_nterror(req, status)) {
-			tevent_req_nterror(req, status);
 			return tevent_req_post(req, ev);
 		}
 	}
diff --git a/source3/libsmb/libsmb_server.c b/source3/libsmb/libsmb_server.c
index c7516639fa3..6454e58519c 100644
--- a/source3/libsmb/libsmb_server.c
+++ b/source3/libsmb/libsmb_server.c
@@ -76,10 +76,8 @@ SMBC_check_server(SMBCCTX * context,
 	 * replied.
 	 * BUG: https://bugzilla.samba.org/show_bug.cgi?id=13218
 	 */
-	if (smbXcli_conn_protocol(cli->conn) >=
-	    PROTOCOL_SMB2_02) {
-		if (NT_STATUS_EQUAL(status,
-				    NT_STATUS_USER_SESSION_DELETED)) {
+	if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
+		if (NT_STATUS_EQUAL(status, NT_STATUS_USER_SESSION_DELETED)) {
 			ok = true;
 		}
 	}
@@ -89,8 +87,7 @@ SMBC_check_server(SMBCCTX * context,
 	 * replied.
 	 * BUG: https://bugzilla.samba.org/show_bug.cgi?id=13007
 	 */
-	if (NT_STATUS_EQUAL(status,
-			    NT_STATUS_INVALID_PARAMETER)) {
+	if (NT_STATUS_EQUAL(status, NT_STATUS_INVALID_PARAMETER)) {
 		ok = true;
 	}
 	if (!ok) {