From: Darrick J. Wong <darrick.wong@oracle.com>
Date: Fri, 9 Nov 2018 19:43:17 +0000 (-0600)
Subject: make: don't spray static check failures all over the subdir  build
X-Git-Tag: v4.19.0~1
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fa001e409a045d5f51264d0af50863207c510064;p=thirdparty%2Fxfsprogs-dev.git

make: don't spray static check failures all over the subdir  build

Debian package building is special -- it directly calls make -C libxfs
when building the debian-installer packages.  This means that any
variables we define in the top level Makefile don't get passed down to
subdir make processes.

This means that the new static checker support effectively runs the
first argument in $(CFLAGS) as a command, which is surprising.  Fix up
buildrules to patch out CHECK_CMD if nobody's defined it, so that direct
subdir make works again.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/include/buildrules b/include/buildrules
index c207a1680..7a139ff07 100644
--- a/include/buildrules
+++ b/include/buildrules
@@ -36,6 +36,10 @@ $(SUBDIRS):
 	$(Q)$(MAKE) $(MAKEOPTS) -q -C $@ || $(MAKE) $(MAKEOPTS) -C $@
 endif
 
+ifndef CHECK_CMD
+CHECK_CMD = @true
+endif
+
 #
 # Standard targets
 #