From: Joel Rosdahl <joel@rosdahl.net>
Date: Wed, 1 May 2019 14:10:18 +0000 (+0200)
Subject: Fix usage of ferror after fclose
X-Git-Tag: v3.7.1~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fa6c04273fd6615de7bfd93cb9f2821838871604;p=thirdparty%2Fccache.git

Fix usage of ferror after fclose
---

diff --git a/src/execute.c b/src/execute.c
index 3ee095346..4ec3a0a97 100644
--- a/src/execute.c
+++ b/src/execute.c
@@ -175,10 +175,10 @@ win32execute(char *path, char **argv, int doreturn,
 		FILE *fp = create_tmp_file(&tmp_file, "w");
 		char atfile[MAX_PATH + 3];
 		fwrite(args, 1, length, fp);
-		fclose(fp);
 		if (ferror(fp)) {
 			cc_log("Error writing @file; this command will probably fail: %s", args);
 		}
+		fclose(fp);
 		snprintf(atfile, sizeof(atfile), "\"@%s\"", tmp_file);
 		ret = CreateProcess(NULL, atfile, NULL, NULL, 1, 0, NULL, NULL,
 		                    &si, &pi);