From: John Gallagher <john@gllghr.com>
Date: Fri, 28 Apr 2023 06:04:31 +0000 (-0700)
Subject: libdwfl: Fix memory leak in unzip()
X-Git-Tag: elfutils-0.190~61
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fa7da8bfad1ec2ac61859aa0b4b09b42ea657ea2;p=thirdparty%2Felfutils.git

libdwfl: Fix memory leak in unzip()

state.input_buffer is not freed if the file is found to not be
compressed with the compression algorithm unzip() is trying to use.

Signed-off-by: John Gallagher <john@gllghr.com>
---

diff --git a/libdwfl/ChangeLog b/libdwfl/ChangeLog
index daef28285..54d859214 100644
--- a/libdwfl/ChangeLog
+++ b/libdwfl/ChangeLog
@@ -1,3 +1,7 @@
+2023-04-24  John Gallagher  <john@gllghr.com>
+
+	* gzip.c: Fix memory leak in unzip()
+
 2023-02-06  Mark Wielaard  <mark@klomp.org>
 
 	* libdwfl.h: Guard debuginfod_client typedef with
diff --git a/libdwfl/gzip.c b/libdwfl/gzip.c
index 53013be3c..002afc4e9 100644
--- a/libdwfl/gzip.c
+++ b/libdwfl/gzip.c
@@ -227,7 +227,7 @@ unzip (int fd, off_t start_offset,
 #endif
       )
     /* Not a compressed file.  */
-    return DWFL_E_BADELF;
+    return fail (&state, DWFL_E_BADELF);
 
 #ifdef ZSTD
   /* special case for libzstd since it is slightly different from the