From: Robert Haas <rhaas@postgresql.org>
Date: Wed, 12 Apr 2023 15:37:13 +0000 (-0400)
Subject: basebackup_to_shell: Check for a NULL return from OpenPipeStream.
X-Git-Tag: REL_15_3~38
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fa83e9e23ca2542d040466d820c3bf8eef930331;p=thirdparty%2Fpostgresql.git

basebackup_to_shell: Check for a NULL return from OpenPipeStream.

Per complaint from Peter Eisentraut.

Discussion: http://postgr.es/m/4f1707cc-2432-da35-64a2-5c2a8d92a388@enterprisedb.com
---

diff --git a/contrib/basebackup_to_shell/basebackup_to_shell.c b/contrib/basebackup_to_shell/basebackup_to_shell.c
index 2099e0f50d8..5a26bc61be9 100644
--- a/contrib/basebackup_to_shell/basebackup_to_shell.c
+++ b/contrib/basebackup_to_shell/basebackup_to_shell.c
@@ -315,6 +315,11 @@ shell_run_command(bbsink_shell *sink, const char *filename)
 
 	/* Run it. */
 	sink->pipe = OpenPipeStream(sink->current_command, PG_BINARY_W);
+	if (sink->pipe == NULL)
+		ereport(ERROR,
+				(errcode_for_file_access(),
+				 errmsg("could not execute command \"%s\": %m",
+						sink->current_command)));
 }
 
 /*