From: Yang Yingliang <yangyingliang@huawei.com>
Date: Wed, 31 Mar 2021 08:36:02 +0000 (+0800)
Subject: net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()
X-Git-Tag: v5.10.37~148
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=faba97afdbb9d3ae4f4829603dc6513f0ad133b6;p=thirdparty%2Fkernel%2Fstable.git

net/tipc: fix missing destroy_workqueue() on error in tipc_crypto_start()

[ Upstream commit ac1db7acea67777be1ba86e36e058c479eab6508 ]

Add the missing destroy_workqueue() before return from
tipc_crypto_start() in the error handling case.

Fixes: 1ef6f7c9390f ("tipc: add automatic session key exchange")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/net/tipc/crypto.c b/net/tipc/crypto.c
index 86eb6d679225c..2301b66280def 100644
--- a/net/tipc/crypto.c
+++ b/net/tipc/crypto.c
@@ -1485,6 +1485,8 @@ int tipc_crypto_start(struct tipc_crypto **crypto, struct net *net,
 	/* Allocate statistic structure */
 	c->stats = alloc_percpu_gfp(struct tipc_crypto_stats, GFP_ATOMIC);
 	if (!c->stats) {
+		if (c->wq)
+			destroy_workqueue(c->wq);
 		kfree_sensitive(c);
 		return -ENOMEM;
 	}