From: luo penghao <luo.penghao@zte.com.cn>
Date: Thu, 4 Nov 2021 06:40:07 +0000 (+0000)
Subject: ext4: remove unused assignments
X-Git-Tag: v5.17-rc1~131^2~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fac888b2be9993d0c740013d26d69c8784acc293;p=thirdparty%2Fkernel%2Flinux.git

ext4: remove unused assignments

The eh assignment in these two places is meaningless, because the
function will goto to merge, which will not use eh.

The clang_analyzer complains as follows:

fs/ext4/extents.c:1988:4 warning:
fs/ext4/extents.c:2016:4 warning:

Value stored to 'eh' is never read

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: luo penghao <luo.penghao@zte.com.cn>
Link: https://lore.kernel.org/r/20211104064007.2919-1-luo.penghao@zte.com
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
---

diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c
index c3e76a5de6615..299d27d04b2b7 100644
--- a/fs/ext4/extents.c
+++ b/fs/ext4/extents.c
@@ -2025,7 +2025,6 @@ int ext4_ext_insert_extent(handle_t *handle, struct inode *inode,
 					+ ext4_ext_get_actual_len(newext));
 			if (unwritten)
 				ext4_ext_mark_unwritten(ex);
-			eh = path[depth].p_hdr;
 			nearex = ex;
 			goto merge;
 		}
@@ -2054,7 +2053,6 @@ prepend:
 					+ ext4_ext_get_actual_len(newext));
 			if (unwritten)
 				ext4_ext_mark_unwritten(ex);
-			eh = path[depth].p_hdr;
 			nearex = ex;
 			goto merge;
 		}