From: Andres Freund <andres@anarazel.de>
Date: Fri, 18 Mar 2016 18:43:59 +0000 (-0700)
Subject: Remove unused, and dangerous, TestLatch() macro.
X-Git-Tag: REL9_6_BETA1~450
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fad0f9d8c9f6a8e99156b8f01cba54be39f31761;p=thirdparty%2Fpostgresql.git

Remove unused, and dangerous, TestLatch() macro.

The macro has not seen any in-tree use since latches had been introduced
in 2746e5f, in 2010.
---

diff --git a/src/include/storage/latch.h b/src/include/storage/latch.h
index e77491e71f3..737e11d0168 100644
--- a/src/include/storage/latch.h
+++ b/src/include/storage/latch.h
@@ -116,8 +116,6 @@ extern int WaitLatchOrSocket(volatile Latch *latch, int wakeEvents,
 extern void SetLatch(volatile Latch *latch);
 extern void ResetLatch(volatile Latch *latch);
 
-/* beware of memory ordering issues if you use this macro! */
-#define TestLatch(latch) (((volatile Latch *) (latch))->is_set)
 
 /*
  * Unix implementation uses SIGUSR1 for inter-process signaling.