From: William Lallemand <wlallemand@haproxy.com>
Date: Wed, 15 Nov 2017 18:02:57 +0000 (+0100)
Subject: BUG/MEDIUM: mworker: does not deinit anymore
X-Git-Tag: v1.8-rc4~13
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fade49d8fbe54ba9643d0fe30534489695bff2fb;p=thirdparty%2Fhaproxy.git

BUG/MEDIUM: mworker: does not deinit anymore

Does not use the deinit() function during a reload, it's dangerous and
might be subject to double free, segfault and hazardous behavior if
it's called twice in the case of a execvp fail.
---

diff --git a/src/haproxy.c b/src/haproxy.c
index b90e2540ba..00cc25b165 100644
--- a/src/haproxy.c
+++ b/src/haproxy.c
@@ -648,7 +648,6 @@ static void mworker_reload()
 		next_argv[next_argc++] = NULL;
 	}
 
-	deinit(); /* we don't want to leak FD there */
 	Warning("Reexecuting Master process\n");
 	execvp(next_argv[0], next_argv);