From: Jonathan Cameron Date: Wed, 29 May 2024 13:34:31 +0000 (+0100) Subject: ACPI: processor: Return an error if acpi_processor_get_info() fails in processor_add() X-Git-Tag: v6.11-rc1~217^2^2~17 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fadf231f0a06a6748a7fc4a2c29ac9ef7bca6bfd;p=thirdparty%2Fkernel%2Flinux.git ACPI: processor: Return an error if acpi_processor_get_info() fails in processor_add() Rafael observed [1] that returning 0 from processor_add() will result in acpi_default_enumeration() being called which will attempt to create a platform device, but that makes little sense when the processor is known to be not available. So just return the error code from acpi_processor_get_info() instead. Link: https://lore.kernel.org/all/CAJZ5v0iKU8ra9jR+EmgxbuNm=Uwx2m1-8vn_RAZ+aCiUVLe3Pw@mail.gmail.com/ [1] Suggested-by: Rafael J. Wysocki Acked-by: Rafael J. Wysocki Reviewed-by: Gavin Shan Signed-off-by: Jonathan Cameron Link: https://lore.kernel.org/r/20240529133446.28446-5-Jonathan.Cameron@huawei.com Signed-off-by: Catalin Marinas --- diff --git a/drivers/acpi/acpi_processor.c b/drivers/acpi/acpi_processor.c index 161c95c9d60ac..5f062806ca402 100644 --- a/drivers/acpi/acpi_processor.c +++ b/drivers/acpi/acpi_processor.c @@ -393,7 +393,7 @@ static int acpi_processor_add(struct acpi_device *device, result = acpi_processor_get_info(device); if (result) /* Processor is not physically present or unavailable */ - return 0; + return result; BUG_ON(pr->id >= nr_cpu_ids);