From: Chengguang Xu <cgxu519@gmail.com>
Date: Sun, 5 May 2019 14:26:06 +0000 (+0800)
Subject: xtensa: fix incorrect fd close in error case of simdisk_setup()
X-Git-Tag: v5.2-rc1~92^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fb1b79d88b88370a8177aefcd446b1b3d323e4c8;p=thirdparty%2Fkernel%2Flinux.git

xtensa: fix incorrect fd close in error case of simdisk_setup()

dev->fd is opened in attach operation, so should not
close dev->fd in error case of simdisk_setup().

Signed-off-by: Chengguang Xu <cgxu519@gmail.com>
Message-Id: <1557066367-4783-1-git-send-email-cgxu519@gmail.com>
Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
---

diff --git a/arch/xtensa/platforms/iss/simdisk.c b/arch/xtensa/platforms/iss/simdisk.c
index 026211e7ab09c..5fac8b781453a 100644
--- a/arch/xtensa/platforms/iss/simdisk.c
+++ b/arch/xtensa/platforms/iss/simdisk.c
@@ -297,7 +297,6 @@ out_alloc_disk:
 	blk_cleanup_queue(dev->queue);
 	dev->queue = NULL;
 out_alloc_queue:
-	simc_close(dev->fd);
 	return -EIO;
 }