From: Tudor Ambarus Date: Thu, 17 Sep 2020 07:52:13 +0000 (+0300) Subject: mtd: rawnand: Don't overwrite the error code from nand_set_ecc_soft_ops() X-Git-Tag: v5.10-rc1~94^2~3^2~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fb8c3810d7c8d2bca01292395e35b85419394f52;p=thirdparty%2Flinux.git mtd: rawnand: Don't overwrite the error code from nand_set_ecc_soft_ops() The error code received from nand_set_ecc_soft_ops() was overwritten, drop this redundant assignment and use the error code received from the callee. Signed-off-by: Tudor Ambarus Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20200917075213.532161-4-tudor.ambarus@microchip.com --- diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c index c7f4ba975e2c5..1f0d542d59230 100644 --- a/drivers/mtd/nand/raw/nand_base.c +++ b/drivers/mtd/nand/raw/nand_base.c @@ -5698,10 +5698,8 @@ static int nand_scan_tail(struct nand_chip *chip) case NAND_ECC_ENGINE_TYPE_SOFT: ret = nand_set_ecc_soft_ops(chip); - if (ret) { - ret = -EINVAL; + if (ret) goto err_nand_manuf_cleanup; - } break; case NAND_ECC_ENGINE_TYPE_ON_DIE: