From: Heikki Krogerus Date: Fri, 16 Aug 2024 13:58:59 +0000 (+0300) Subject: usb: typec: ucsi: Remove useless error check from ucsi_read_error() X-Git-Tag: v6.12-rc1~42^2~80 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fb9804096bb3508e33ade5a72f2332080cf1324b;p=thirdparty%2Fkernel%2Flinux.git usb: typec: ucsi: Remove useless error check from ucsi_read_error() If the GET_ERROR_STATUS command fails, ucsi_read_error() can not reach the condition where the CCI error bit is checked, because ucsi_run_command() has already checked that bit and returned an error. Signed-off-by: Heikki Krogerus Link: https://lore.kernel.org/r/20240816135859.3499351-7-heikki.krogerus@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/typec/ucsi/ucsi.c b/drivers/usb/typec/ucsi/ucsi.c index 8be10a2071212..f0b5867048e25 100644 --- a/drivers/usb/typec/ucsi/ucsi.c +++ b/drivers/usb/typec/ucsi/ucsi.c @@ -148,9 +148,6 @@ static int ucsi_read_error(struct ucsi *ucsi, u8 connector_num) if (ret < 0) return ret; - if (cci & UCSI_CCI_ERROR) - return -EIO; - switch (error) { case UCSI_ERROR_INCOMPATIBLE_PARTNER: return -EOPNOTSUPP;