From: David S. Miller Date: Wed, 19 Apr 2023 12:04:31 +0000 (+0100) Subject: Merge branch 'skbuff-bitfields' X-Git-Tag: v6.4-rc1~132^2~57 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fbb192a836bee873e4e94c5deca19bf558ab7bb9;p=thirdparty%2Fkernel%2Flinux.git Merge branch 'skbuff-bitfields' Jakub Kicinski says: ==================== net: skbuff: hide some bitfield members There is a number of protocol or subsystem specific fields in struct sk_buff which are only accessed by one subsystem. We can wrap them in ifdefs with minimal code impact. This gives us a better chance to save a 2B and a 4B holes resulting with the following savings (assuming a lucky kernel config): - /* size: 232, cachelines: 4, members: 28 */ - /* sum members: 227, holes: 1, sum holes: 4 */ - /* sum bitfield members: 8 bits (1 bytes) */ + /* size: 224, cachelines: 4, members: 28 */ /* forced alignments: 2 */ - /* last cacheline: 40 bytes */ + /* last cacheline: 32 bytes */ I think that the changes shouldn't be too controversial. The only one I'm not 100% sure of is the SCTP one, 12 extra LoC for one bit.. But it did fit squarely in the "this bit has only one user" category. ==================== Signed-off-by: David S. Miller Acked-by: Simon Horman --- fbb192a836bee873e4e94c5deca19bf558ab7bb9