From: Petr Machata <pmachata@redhat.com>
Date: Sat, 13 Sep 2014 22:47:42 +0000 (+0200)
Subject: readelf: Fix typo in a check in handle_relocs_rela
X-Git-Tag: elfutils-0.161~108
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fbf1a44f0f2ccda6a3f725ebb8ae723e0e607d8b;p=thirdparty%2Felfutils.git

readelf: Fix typo in a check in handle_relocs_rela

- Testing shdr makes no sense, that pointer was dereferenced several
  times throughout the section.  destshdr on the other hand is not
  tested at all.

Signed-off-by: Petr Machata <pmachata@redhat.com>
---

diff --git a/src/ChangeLog b/src/ChangeLog
index aa986080c..a252cdcdc 100644
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,7 @@
+2014-09-14  Petr Machata  <pmachata@redhat.com>
+
+	* readelf.c (handle_relocs_rela): Typo fix, test DESTSHDR properly.
+
 2014-09-12  Petr Machata  <pmachata@redhat.com>
 
 	* readelf.c (encoded_ptr_size): In the switch statement, change
diff --git a/src/readelf.c b/src/readelf.c
index 7b43a6586..4d3bb3630 100644
--- a/src/readelf.c
+++ b/src/readelf.c
@@ -2090,7 +2090,7 @@ handle_relocs_rela (Ebl *ebl, GElf_Ehdr *ehdr, Elf_Scn *scn, GElf_Shdr *shdr)
 						   ? xndx : sym->st_shndx),
 				       &destshdr_mem);
 
-	      if (unlikely (shdr == NULL))
+	      if (unlikely (destshdr == NULL))
 		printf ("  %#0*" PRIx64 "  %-15s <%s %ld>\n",
 			class == ELFCLASS32 ? 10 : 18, rel->r_offset,
 			ebl_reloc_type_check (ebl, GELF_R_TYPE (rel->r_info))