From: Timo Sirainen <timo.sirainen@dovecot.fi>
Date: Mon, 20 Jun 2016 08:33:47 +0000 (+0300)
Subject: lib-dcrypt: dcrypt_keypair_generate() no longer assumes pair_r to be initialized.
X-Git-Tag: 2.3.0.rc1~3434
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fbf29f41d25c13d9ad772facdf047e2bd8370ba1;p=thirdparty%2Fdovecot%2Fcore.git

lib-dcrypt: dcrypt_keypair_generate() no longer assumes pair_r to be initialized.

It wasn't clear that it should have been zeroed. It also likely isn't very
useful to be able to place the generated key to existing keys.
---

diff --git a/src/lib-dcrypt/dcrypt.c b/src/lib-dcrypt/dcrypt.c
index a6845ad4e4..7592aa8a91 100644
--- a/src/lib-dcrypt/dcrypt.c
+++ b/src/lib-dcrypt/dcrypt.c
@@ -196,6 +196,7 @@ bool dcrypt_pbkdf2(const unsigned char *password, size_t password_len, const uns
 
 bool dcrypt_keypair_generate(struct dcrypt_keypair *pair_r, enum dcrypt_key_type kind, unsigned int bits, const char *curve, const char **error_r)
 {
+	memset(pair_r, 0, sizeof(*pair_r));
 	return dcrypt_vfs->generate_keypair(pair_r, kind, bits, curve, error_r);
 }