From: Philippe Mathieu-Daudé <philmd@linaro.org>
Date: Mon, 8 Apr 2024 09:41:59 +0000 (+0200)
Subject: hw/misc/applesmc: Fix memory leak in reset() handler
X-Git-Tag: v9.0.0-rc3~1^2~6
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc09ff2979defdcf8d00c2db94022d5d610e36ba;p=thirdparty%2Fqemu.git

hw/misc/applesmc: Fix memory leak in reset() handler

AppleSMCData is allocated with g_new0() in applesmc_add_key():
release it with g_free().

Leaked since commit 1ddda5cd36 ("AppleSMC device emulation").

Cc: qemu-stable@nongnu.org
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2272
Reported-by: Zheyu Ma <zheyuma97@gmail.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20240408095217.57239-3-philmd@linaro.org>
---

diff --git a/hw/misc/applesmc.c b/hw/misc/applesmc.c
index 8e65816da66..14e3ef667d8 100644
--- a/hw/misc/applesmc.c
+++ b/hw/misc/applesmc.c
@@ -274,6 +274,7 @@ static void qdev_applesmc_isa_reset(DeviceState *dev)
     /* Remove existing entries */
     QLIST_FOREACH_SAFE(d, &s->data_def, node, next) {
         QLIST_REMOVE(d, node);
+        g_free(d);
     }
     s->status = 0x00;
     s->status_1e = 0x00;