From: Wei Yongjun Date: Thu, 22 Mar 2018 02:11:48 +0000 (+0000) Subject: clk: davinci: Remove redundant dev_err calls X-Git-Tag: v4.17-rc1~18^2~2^2 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc3fcb4ff1960e9f0b72b1d4855f7e0bcf18b7f2;p=thirdparty%2Fkernel%2Flinux.git clk: davinci: Remove redundant dev_err calls There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Reviewed-by: David Lechner Signed-off-by: Stephen Boyd --- diff --git a/drivers/clk/davinci/pll.c b/drivers/clk/davinci/pll.c index 89d30bf951023..23a24c944f1d2 100644 --- a/drivers/clk/davinci/pll.c +++ b/drivers/clk/davinci/pll.c @@ -814,10 +814,8 @@ static int davinci_pll_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } return pll_init(dev, base); } diff --git a/drivers/clk/davinci/psc.c b/drivers/clk/davinci/psc.c index 3b0e59dfbdd76..ff6f4a038e047 100644 --- a/drivers/clk/davinci/psc.c +++ b/drivers/clk/davinci/psc.c @@ -521,10 +521,8 @@ static int davinci_psc_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); base = devm_ioremap_resource(dev, res); - if (IS_ERR(base)) { - dev_err(dev, "ioremap failed\n"); + if (IS_ERR(base)) return PTR_ERR(base); - } ret = devm_clk_bulk_get(dev, init_data->num_parent_clks, init_data->parent_clks);