From: SZEDER Gábor <szeder.dev@gmail.com>
Date: Mon, 25 Nov 2019 12:59:07 +0000 (+0100)
Subject: test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'
X-Git-Tag: v2.25.0-rc0~43^2
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc42f20e243db941fb58e5ef43e3654034738326;p=thirdparty%2Fgit.git

test-lib-functions: suppress a 'git rev-parse' error in 'test_commit_bulk'

When 'test_commit_bulk' is invoked in an empty test repository, it
prints a "fatal: Needed a single revision" error, but still does what
it's supposed to do.  A test helper function displaying a fatal error
and still succeeding is always suspect to be buggy, but luckily that's
not the case here: that error comes from a 'git rev-parse --verify
HEAD' command invoked in a condition, which doesn't have anything to
verify in an empty repository.

Use the '--quiet' option to suppress that error message.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---

diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
index e0b3f28d3a..a2e9d6ae2e 100644
--- a/t/test-lib-functions.sh
+++ b/t/test-lib-functions.sh
@@ -306,7 +306,7 @@ test_commit_bulk () {
 	total=$1
 
 	add_from=
-	if git -C "$indir" rev-parse --verify "$ref"
+	if git -C "$indir" rev-parse --quiet --verify "$ref"
 	then
 		add_from=t
 	fi