From: Daniel Stenberg <daniel@haxx.se>
Date: Tue, 31 Jan 2023 11:34:08 +0000 (+0100)
Subject: escape: use table lookup when adding %-codes to output
X-Git-Tag: curl-7_88_0~88
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc8ad0b23c9fd922ebdb89348d467df037da1775;p=thirdparty%2Fcurl.git

escape: use table lookup when adding %-codes to output

On my dev host, this code runs 7.8 times faster.

Closes #10377
---

diff --git a/lib/escape.c b/lib/escape.c
index 93db06cbd8..56aa2b3988 100644
--- a/lib/escape.c
+++ b/lib/escape.c
@@ -97,7 +97,7 @@ char *curl_easy_escape(struct Curl_easy *data, const char *string,
     return strdup("");
 
   while(length--) {
-    unsigned char in = *string; /* we need to treat the characters unsigned */
+    unsigned char in = *string++; /* treat the characters unsigned */
 
     if(Curl_isunreserved(in)) {
       /* append this */
@@ -106,10 +106,13 @@ char *curl_easy_escape(struct Curl_easy *data, const char *string,
     }
     else {
       /* encode it */
-      if(Curl_dyn_addf(&d, "%%%02X", in))
+      const char hex[] = "0123456789ABCDEF";
+      char out[3]={'%'};
+      out[1] = hex[in>>4];
+      out[2] = hex[in & 0xf];
+      if(Curl_dyn_addn(&d, out, 3))
         return NULL;
     }
-    string++;
   }
 
   return Curl_dyn_ptr(&d);