From: Willy Tarreau <w@1wt.eu>
Date: Thu, 17 Jun 2021 05:22:27 +0000 (+0200)
Subject: BUG/MINOR: stats: make "show stat typed desc" work again
X-Git-Tag: v2.5-dev1~104
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc8e438637aa926e681c8b7f3fa061021dfb2201;p=thirdparty%2Fhaproxy.git

BUG/MINOR: stats: make "show stat typed desc" work again

As part of the changes to support per-module stats data in 2.3-dev6
with commit ee63d4bd6 ("MEDIUM: stats: integrate static proxies stats
in new stats"), a small change resulted in the description field to
be replaced by the name field, making it pointless. Let's fix this
back.

This should fix issue #1291. Thanks to Nick Ramirez for reporting this
issue.

This patch can be backported to 2.3.
---

diff --git a/src/stats.c b/src/stats.c
index a35ef0d893..0b743d1899 100644
--- a/src/stats.c
+++ b/src/stats.c
@@ -637,8 +637,8 @@ static int stats_dump_fields_typed(struct buffer *out,
 		if (!stats_emit_typed_data_field(out, &stats[field]))
 			return 0;
 
-		if (flags & STAT_SHOW_FDESC
-		    && !chunk_appendf(out, ":\"%s\"", stat_f[domain][field].name)) {
+		if (flags & STAT_SHOW_FDESC &&
+		    !chunk_appendf(out, ":\"%s\"", stat_f[domain][field].desc)) {
 			return 0;
 		}