From: Andrew Goodbody Date: Wed, 6 Aug 2025 17:03:26 +0000 (+0100) Subject: phy: ti: j721e-wiz: Set error code before goto X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fc96c1de5b719561db15259009a9ef22e671ee3d;p=thirdparty%2Fu-boot.git phy: ti: j721e-wiz: Set error code before goto In j721e_wiz_probe the test for too many lanes jumps to the error exit path without assigning an error code which could lead to calling code silently ignoring the failure. Set the error code. This issue was found by Smatch. Signed-off-by: Andrew Goodbody --- diff --git a/drivers/phy/ti/phy-j721e-wiz.c b/drivers/phy/ti/phy-j721e-wiz.c index c69a342e2b4..6e2d4bc2b05 100644 --- a/drivers/phy/ti/phy-j721e-wiz.c +++ b/drivers/phy/ti/phy-j721e-wiz.c @@ -1201,6 +1201,7 @@ static int j721e_wiz_probe(struct udevice *dev) if (num_lanes > WIZ_MAX_LANES) { dev_err(dev, "Cannot support %d lanes\n", num_lanes); + rc = -EINVAL; goto err_addr_to_resource; }