From: Phil Sutter <phil@nwl.cc>
Date: Thu, 12 Aug 2021 17:11:59 +0000 (+0200)
Subject: tests: iptables-test: Fix missing chain case
X-Git-Tag: v1.8.8~131
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fcbe454bf0d05612a8484723fd3e9299d4ee836f;p=thirdparty%2Fiptables.git

tests: iptables-test: Fix missing chain case

If a chain line was really missing, Python complained about reference
before assignment of 'chain_array' variable. While being at it, reuse
print_error() function for reporting and allow to continue with the next
input file instead of exiting.

Signed-off-by: Phil Sutter <phil@nwl.cc>
---

diff --git a/iptables-test.py b/iptables-test.py
index 90e07fee..01966f91 100755
--- a/iptables-test.py
+++ b/iptables-test.py
@@ -215,6 +215,7 @@ def run_test_file(filename, netns):
     tests = 0
     passed = 0
     table = ""
+    chain_array = []
     total_test_passed = True
 
     if netns:
@@ -249,8 +250,10 @@ def run_test_file(filename, netns):
             continue
 
         if len(chain_array) == 0:
-            print("broken test, missing chain, leaving")
-            sys.exit()
+            print_error("broken test, missing chain",
+                        filename = filename, lineno = lineno)
+            total_test_passed = False
+            break
 
         test_passed = True
         tests += 1