From: Kent Overstreet <kent.overstreet@gmail.com>
Date: Mon, 14 Feb 2022 09:20:39 +0000 (-0500)
Subject: bcachefs: Kill verify_not_stale()
X-Git-Tag: v6.7-rc1~201^2~1144
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fcf01959eaa828b1005f8f30732949e64edb8c4d;p=thirdparty%2Fkernel%2Flinux.git

bcachefs: Kill verify_not_stale()

This is ancient code that's more effectively checked in other places
now.

Signed-off-by: Kent Overstreet <kent.overstreet@gmail.com>
---

diff --git a/fs/bcachefs/alloc_foreground.c b/fs/bcachefs/alloc_foreground.c
index e2038032b872a..dc2f153f60c6f 100644
--- a/fs/bcachefs/alloc_foreground.c
+++ b/fs/bcachefs/alloc_foreground.c
@@ -151,22 +151,6 @@ static void open_bucket_free_unused(struct bch_fs *c,
 	}
 }
 
-static void verify_not_stale(struct bch_fs *c, const struct open_buckets *obs)
-{
-#ifdef CONFIG_BCACHEFS_DEBUG
-	struct open_bucket *ob;
-	unsigned i;
-
-	rcu_read_lock();
-	open_bucket_for_each(c, obs, ob, i) {
-		struct bch_dev *ca = bch_dev_bkey_exists(c, ob->dev);
-
-		BUG_ON(*bucket_gen(ca, ob->bucket) != ob->gen);
-	}
-	rcu_read_unlock();
-#endif
-}
-
 /* _only_ for allocating the journal on a new device: */
 long bch2_bucket_alloc_new_fs(struct bch_dev *ca)
 {
@@ -857,8 +841,6 @@ alloc_done:
 
 	BUG_ON(!wp->sectors_free || wp->sectors_free == UINT_MAX);
 
-	verify_not_stale(c, &wp->ptrs);
-
 	return wp;
 err:
 	open_bucket_for_each(c, &wp->ptrs, ob, i)