From: Greg Kroah-Hartman Date: Mon, 3 Nov 2014 19:48:30 +0000 (-0800) Subject: 3.10-stable patches X-Git-Tag: v3.10.60~85 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd206b32c7258c2452692d5ff1b15164d040737e;p=thirdparty%2Fkernel%2Fstable-queue.git 3.10-stable patches added patches: tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch --- diff --git a/queue-3.10/series b/queue-3.10/series new file mode 100644 index 00000000000..52685951e14 --- /dev/null +++ b/queue-3.10/series @@ -0,0 +1 @@ +tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch diff --git a/queue-3.10/tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch b/queue-3.10/tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch new file mode 100644 index 00000000000..283262ec4b6 --- /dev/null +++ b/queue-3.10/tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch @@ -0,0 +1,88 @@ +From 086ba77a6db00ed858ff07451bedee197df868c9 Mon Sep 17 00:00:00 2001 +From: Rabin Vincent +Date: Wed, 29 Oct 2014 23:06:58 +0100 +Subject: tracing/syscalls: Ignore numbers outside NR_syscalls' range + +From: Rabin Vincent + +commit 086ba77a6db00ed858ff07451bedee197df868c9 upstream. + +ARM has some private syscalls (for example, set_tls(2)) which lie +outside the range of NR_syscalls. If any of these are called while +syscall tracing is being performed, out-of-bounds array access will +occur in the ftrace and perf sys_{enter,exit} handlers. + + # trace-cmd record -e raw_syscalls:* true && trace-cmd report + ... + true-653 [000] 384.675777: sys_enter: NR 192 (0, 1000, 3, 4000022, ffffffff, 0) + true-653 [000] 384.675812: sys_exit: NR 192 = 1995915264 + true-653 [000] 384.675971: sys_enter: NR 983045 (76f74480, 76f74000, 76f74b28, 76f74480, 76f76f74, 1) + true-653 [000] 384.675988: sys_exit: NR 983045 = 0 + ... + + # trace-cmd record -e syscalls:* true + [ 17.289329] Unable to handle kernel paging request at virtual address aaaaaace + [ 17.289590] pgd = 9e71c000 + [ 17.289696] [aaaaaace] *pgd=00000000 + [ 17.289985] Internal error: Oops: 5 [#1] PREEMPT SMP ARM + [ 17.290169] Modules linked in: + [ 17.290391] CPU: 0 PID: 704 Comm: true Not tainted 3.18.0-rc2+ #21 + [ 17.290585] task: 9f4dab00 ti: 9e710000 task.ti: 9e710000 + [ 17.290747] PC is at ftrace_syscall_enter+0x48/0x1f8 + [ 17.290866] LR is at syscall_trace_enter+0x124/0x184 + +Fix this by ignoring out-of-NR_syscalls-bounds syscall numbers. + +Commit cd0980fc8add "tracing: Check invalid syscall nr while tracing syscalls" +added the check for less than zero, but it should have also checked +for greater than NR_syscalls. + +Link: http://lkml.kernel.org/p/1414620418-29472-1-git-send-email-rabin@rab.in + +Fixes: cd0980fc8add "tracing: Check invalid syscall nr while tracing syscalls" +Signed-off-by: Rabin Vincent +Signed-off-by: Steven Rostedt +Signed-off-by: Greg Kroah-Hartman + +--- + kernel/trace/trace_syscalls.c | 8 ++++---- + 1 file changed, 4 insertions(+), 4 deletions(-) + +--- a/kernel/trace/trace_syscalls.c ++++ b/kernel/trace/trace_syscalls.c +@@ -312,7 +312,7 @@ static void ftrace_syscall_enter(void *d + int size; + + syscall_nr = trace_get_syscall_nr(current, regs); +- if (syscall_nr < 0) ++ if (syscall_nr < 0 || syscall_nr >= NR_syscalls) + return; + if (!test_bit(syscall_nr, tr->enabled_enter_syscalls)) + return; +@@ -354,7 +354,7 @@ static void ftrace_syscall_exit(void *da + int syscall_nr; + + syscall_nr = trace_get_syscall_nr(current, regs); +- if (syscall_nr < 0) ++ if (syscall_nr < 0 || syscall_nr >= NR_syscalls) + return; + if (!test_bit(syscall_nr, tr->enabled_exit_syscalls)) + return; +@@ -557,7 +557,7 @@ static void perf_syscall_enter(void *ign + int size; + + syscall_nr = trace_get_syscall_nr(current, regs); +- if (syscall_nr < 0) ++ if (syscall_nr < 0 || syscall_nr >= NR_syscalls) + return; + if (!test_bit(syscall_nr, enabled_perf_enter_syscalls)) + return; +@@ -633,7 +633,7 @@ static void perf_syscall_exit(void *igno + int size; + + syscall_nr = trace_get_syscall_nr(current, regs); +- if (syscall_nr < 0) ++ if (syscall_nr < 0 || syscall_nr >= NR_syscalls) + return; + if (!test_bit(syscall_nr, enabled_perf_exit_syscalls)) + return; diff --git a/queue-3.14/series b/queue-3.14/series new file mode 100644 index 00000000000..52685951e14 --- /dev/null +++ b/queue-3.14/series @@ -0,0 +1 @@ +tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch diff --git a/queue-3.17/series b/queue-3.17/series new file mode 100644 index 00000000000..1206dd90e4f --- /dev/null +++ b/queue-3.17/series @@ -0,0 +1,2 @@ +tracing-syscalls-ignore-numbers-outside-nr_syscalls-range.patch +kvm-emulator-fix-execution-close-to-the-segment-limit.patch