From: Giampaolo Rodolà <g.rodola@gmail.com>
Date: Wed, 12 May 2010 00:29:27 +0000 (+0000)
Subject: Removed the assertion that dispatcher.connected attribute must be False after a singl... 
X-Git-Tag: v2.7rc1~173
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd25594aa4180581cf02f2fb2d4dc51e7e4a1262;p=thirdparty%2FPython%2Fcpython.git

Removed the assertion that dispatcher.connected attribute must be False after a single connect() call. Solaris and FreeBSD buildbots failures showed how connect() can succeed even in a single call. All bo failures should definitively be fixed now.
---

diff --git a/Lib/test/test_asyncore.py b/Lib/test/test_asyncore.py
index 2fb40b96ea25..ed4c8a303844 100644
--- a/Lib/test/test_asyncore.py
+++ b/Lib/test/test_asyncore.py
@@ -618,12 +618,8 @@ class BaseTestAPI(unittest.TestCase):
         # we start disconnected
         self.assertFalse(server.connected)
         self.assertTrue(server.accepting)
-        # XXX - Solaris seems to connect() immediately even without
-        # starting the poller. This is something which should be
-        # fixed as handle_connect() gets called immediately even if
-        # no connection actually took place (see issue #8490).
-        if not sys.platform.startswith("sunos"):
-            self.assertFalse(client.connected)
+        # this can't be taken for granted across all platforms
+        #self.assertFalse(client.connected)
         self.assertFalse(client.accepting)
 
         # execute some loops so that client connects to server