From: Alberto Leiva Popper Date: Thu, 29 Jul 2021 20:53:43 +0000 (-0500) Subject: TODOs: Reprioritize X-Git-Tag: v1.5.1~3 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd47e886756ab5c3393a494bce249b97ee4c3ae0;p=thirdparty%2FFORT-validator.git TODOs: Reprioritize There were a lot of FIXMEs that were minor nice-to-haves at best. --- diff --git a/src/asn1/asn1c/INTEGER.c b/src/asn1/asn1c/INTEGER.c index d64c458e..919ef7d1 100644 --- a/src/asn1/asn1c/INTEGER.c +++ b/src/asn1/asn1c/INTEGER.c @@ -870,7 +870,7 @@ asn_INTEGER2imax(const INTEGER_t *iptr, intmax_t *lptr) { return 0; } -/* FIXME: negative INTEGER values are silently interpreted as large unsigned ones. */ +/* TODO (asn1c) negative INTEGER values are silently interpreted as large unsigned ones. */ int asn_INTEGER2umax(const INTEGER_t *iptr, uintmax_t *lptr) { uint8_t *b, *end; diff --git a/src/asn1/asn1c/ber_decoder.c b/src/asn1/asn1c/ber_decoder.c index 4dcf78b0..6cbcb8a3 100644 --- a/src/asn1/asn1c/ber_decoder.c +++ b/src/asn1/asn1c/ber_decoder.c @@ -213,11 +213,9 @@ ber_check_tags(const asn_codec_ctx_t *opt_codec_ctx, } /* - * FIXME - * As of today, the chain of tags - * must either contain several indefinite length TLVs, - * or several definite length ones. - * No mixing is allowed. + * TODO (fine) As of today, the chain of tags must either + * contain several indefinite length TLVs, or several definite + * length ones. No mixing is allowed. */ if(tlv_len == -1) { /* diff --git a/src/asn1/decode.c b/src/asn1/decode.c index f4703d1d..a7652946 100644 --- a/src/asn1/decode.c +++ b/src/asn1/decode.c @@ -52,7 +52,7 @@ der_coder(const void *buf, size_t size, void *app_key) } /* - * FIXME (next iteration) This isn't efficient, consider implement DER decoding + * TODO (performance) This isn't efficient, consider implement DER decoding * or something better. */ static int diff --git a/src/asn1/oid.c b/src/asn1/oid.c index d7018d31..6f4043d8 100644 --- a/src/asn1/oid.c +++ b/src/asn1/oid.c @@ -16,7 +16,7 @@ free_arcs(struct oid_arcs *arcs) * * Callers must free @result. * - * TODO (whatever) Most of the time, this function is called to compare @result + * TODO (fine) Most of the time, this function is called to compare @result * to some oid. Maybe create a wrapper that takes care of all the boilerplate. */ int diff --git a/src/config.c b/src/config.c index fe0e4b78..5f2ff73e 100644 --- a/src/config.c +++ b/src/config.c @@ -40,7 +40,7 @@ struct rpki_config { char *tal; /** Path of our local clone of the repository */ char *local_repository; - /** FIXME (later) Deprecated, remove it. RSYNC download strategy. */ + /** TODO (later) Deprecated, remove it. RSYNC download strategy. */ enum rsync_strategy sync_strategy; /** * Handle TAL URIs in random order? @@ -1042,7 +1042,7 @@ set_default_values(void) rpki_config.http.ca_path = NULL; /* Use system default */ /* - * FIXME (later) Same values as http.*, delete when rrdp.* is fully + * TODO (later) Same values as http.*, delete when rrdp.* is fully * deprecated */ rpki_config.rrdp.enabled = rpki_config.http.enabled; @@ -1153,7 +1153,7 @@ validate_config(void) !valid_file_or_dir(rpki_config.slurm, true, true, __pr_op_err)) return pr_op_err("Invalid slurm location."); - /* FIXME (later) Remove when sync-strategy is fully deprecated */ + /* TODO (later) Remove when sync-strategy is fully deprecated */ if (!rpki_config.rsync.enabled) config_set_sync_strategy(RSYNC_OFF); diff --git a/src/config.h b/src/config.h index d072db2b..3a7deca4 100644 --- a/src/config.h +++ b/src/config.h @@ -79,14 +79,14 @@ uint32_t config_get_val_log_facility(void); */ void config_set_rsync_enabled(bool); void config_set_http_enabled(bool); -/* FIXME (later) This will be deprecated */ +/* TODO (later) This will be deprecated */ void config_set_rrdp_enabled(bool); -/* FIXME (later) Remove when sync-strategy is fully deprecated */ +/* TODO (later) Remove when sync-strategy is fully deprecated */ void config_set_sync_strategy(enum rsync_strategy); void config_set_rsync_strategy(enum rsync_strategy); -/* FIXME (later) Remove once rrdp.* is fully deprecated */ +/* TODO (later) Remove once rrdp.* is fully deprecated */ void config_set_rrdp_priority(unsigned int); void config_set_http_priority(unsigned int); void config_set_rrdp_retry_count(unsigned int); diff --git a/src/config/rrdp_conf.c b/src/config/rrdp_conf.c index 4ec952f2..ee533196 100644 --- a/src/config/rrdp_conf.c +++ b/src/config/rrdp_conf.c @@ -13,7 +13,7 @@ * Note that this is just a wrapper to set rrdp.* arguments and its equivalent * http.* args. * - * FIXME (later) This wrapper will live until all rrdp.* args are fully + * TODO (later) This wrapper will live until all rrdp.* args are fully * deprecated. */ diff --git a/src/config/rsync_strategy.c b/src/config/rsync_strategy.c index b9b3a1dd..0131ec83 100644 --- a/src/config/rsync_strategy.c +++ b/src/config/rsync_strategy.c @@ -60,7 +60,7 @@ parse_argv_rsync_strategy(struct option_field const *field, char const *str, return pr_op_err("Unknown rsync synchronization strategy: '%s'", str); - /* FIXME (later) Remove when sync-strategy is fully deprecated */ + /* TODO (later) Remove when sync-strategy is fully deprecated */ config_set_sync_strategy(DEREFERENCE(result)); return 0; diff --git a/src/config/rsync_strategy.h b/src/config/rsync_strategy.h index 11683bdd..620cff60 100644 --- a/src/config/rsync_strategy.h +++ b/src/config/rsync_strategy.h @@ -5,7 +5,7 @@ enum rsync_strategy { /* - * FIXME (later) Deprecated. Still alive so that 'sync-strategy' and + * TODO (later) Deprecated. Still alive so that 'sync-strategy' and * 'rsync.strategy' can live together. * * 'sync-strategy' type must handle this value to set 'rsync.enabled' @@ -63,7 +63,7 @@ enum rsync_strategy { extern const struct global_type gt_rsync_strategy; /* - * FIXME (later) Public to live along with 'sync-strategy', return them to + * TODO (later) Public to live along with 'sync-strategy', return them to * private whenever 'sync-strategy' is deleted. */ void print_rsync_strategy(struct option_field const *, void *);