From: Ján Tomko <jtomko@redhat.com>
Date: Fri, 20 Nov 2020 13:05:54 +0000 (+0100)
Subject: udevConnectListAllInterfaces: initialize ret
X-Git-Tag: v7.0.0-rc1~383
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd5df67dce231b447e02b8ba6648d158b84cc584;p=thirdparty%2Flibvirt.git

udevConnectListAllInterfaces: initialize ret

Currently, ret is only used in the 'cleanup' section
and initialized right before the jump.

Switch to the customary initialization to -1 and only
leave in the 'ret = 0' statement on an empty list.

Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
---

diff --git a/src/interface/interface_backend_udev.c b/src/interface/interface_backend_udev.c
index ce007fd29e..31246dde74 100644
--- a/src/interface/interface_backend_udev.c
+++ b/src/interface/interface_backend_udev.c
@@ -303,7 +303,7 @@ udevConnectListAllInterfaces(virConnectPtr conn,
     int tmp_count;
     int count = 0;
     int status = 0;
-    int ret;
+    int ret = -1;
 
     virCheckFlags(VIR_CONNECT_LIST_INTERFACES_FILTERS_ACTIVE, -1);
 
@@ -320,7 +320,6 @@ udevConnectListAllInterfaces(virConnectPtr conn,
         virReportError(VIR_ERR_INTERNAL_ERROR,
                        _("failed to get list of %s interfaces on host"),
                        virUdevStatusString(status));
-        ret = -1;
         goto cleanup;
     }