From: Stefan Metzmacher Date: Mon, 3 Oct 2011 21:50:48 +0000 (-0700) Subject: s3:smb2_server: add smbd_smb2_request_verify_sizes() X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd6abe0c92cb22d26615ea443e0ede288ab37a6e;p=thirdparty%2Fsamba.git s3:smb2_server: add smbd_smb2_request_verify_sizes() metze. --- diff --git a/source3/smbd/globals.h b/source3/smbd/globals.h index abeaed41d43..70338489402 100644 --- a/source3/smbd/globals.h +++ b/source3/smbd/globals.h @@ -278,6 +278,9 @@ NTSTATUS smbd_smb2_request_check_tcon(struct smbd_smb2_request *req); struct smb_request *smbd_smb2_fake_smb_request(struct smbd_smb2_request *req); void remove_smb2_chained_fsp(files_struct *fsp); +NTSTATUS smbd_smb2_request_verify_sizes(struct smbd_smb2_request *req, + size_t expected_body_size); + NTSTATUS smbd_smb2_request_process_negprot(struct smbd_smb2_request *req); NTSTATUS smbd_smb2_request_process_sesssetup(struct smbd_smb2_request *req); NTSTATUS smbd_smb2_request_process_logoff(struct smbd_smb2_request *req); diff --git a/source3/smbd/smb2_server.c b/source3/smbd/smb2_server.c index cad4ca662a0..811e6d3d65b 100644 --- a/source3/smbd/smb2_server.c +++ b/source3/smbd/smb2_server.c @@ -1125,6 +1125,48 @@ static NTSTATUS smbd_smb2_request_process_cancel(struct smbd_smb2_request *req) return NT_STATUS_OK; } +NTSTATUS smbd_smb2_request_verify_sizes(struct smbd_smb2_request *req, + size_t expected_body_size) +{ + const uint8_t *inbody; + int i = req->current_idx; + size_t body_size; + + /* + * The following should be checked already. + */ + if ((i+2) > req->in.vector_count) { + return NT_STATUS_INTERNAL_ERROR; + } + if (req->in.vector[i+0].iov_len != SMB2_HDR_BODY) { + return NT_STATUS_INTERNAL_ERROR; + } + if (req->in.vector[i+1].iov_len < 2) { + return NT_STATUS_INTERNAL_ERROR; + } + + /* + * Now check the expected body size, + * where the last byte might be in the + * dynnamic section.. + */ + if (req->in.vector[i+1].iov_len != (expected_body_size & 0xFFFFFFFE)) { + return NT_STATUS_INVALID_PARAMETER; + } + if (req->in.vector[i+2].iov_len < (expected_body_size & 0x00000001)) { + return NT_STATUS_INVALID_PARAMETER; + } + + inbody = (const uint8_t *)req->in.vector[i+1].iov_base; + + body_size = SVAL(inbody, 0x00); + if (body_size != expected_body_size) { + return NT_STATUS_INVALID_PARAMETER; + } + + return NT_STATUS_OK; +} + NTSTATUS smbd_smb2_request_dispatch(struct smbd_smb2_request *req) { const uint8_t *inhdr;