From: Russell King (Oracle) Date: Thu, 28 Oct 2021 14:55:34 +0000 (+0100) Subject: net: phylink: avoid mvneta warning when setting pause parameters X-Git-Tag: v5.16-rc1~159^2~1^2~7 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd8d9731bcdfb22d28e45bce789bcb211c868c78;p=thirdparty%2Fkernel%2Flinux.git net: phylink: avoid mvneta warning when setting pause parameters mvneta does not support asymetric pause modes, and it flags this by the lack of AsymPause in the supported field. When setting pause modes, we check that pause->rx_pause == pause->tx_pause, but only when pause autoneg is enabled. When pause autoneg is disabled, we still allow pause->rx_pause != pause->tx_pause, which is incorrect when the MAC does not support asymetric pause, and causes mvneta to issue a warning. Fix this by removing the test for pause->autoneg, so we always check that pause->rx_pause == pause->tx_pause for network devices that do not support AsymPause. Fixes: 9525ae83959b ("phylink: add phylink infrastructure") Signed-off-by: Russell King (Oracle) Signed-off-by: David S. Miller --- diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c index 0a0abe8e4be0b..5defc721dd05d 100644 --- a/drivers/net/phy/phylink.c +++ b/drivers/net/phy/phylink.c @@ -1724,7 +1724,7 @@ int phylink_ethtool_set_pauseparam(struct phylink *pl, return -EOPNOTSUPP; if (!phylink_test(pl->supported, Asym_Pause) && - !pause->autoneg && pause->rx_pause != pause->tx_pause) + pause->rx_pause != pause->tx_pause) return -EINVAL; pause_state = 0;