From: Rob Herring (Arm) Date: Thu, 8 Aug 2024 17:06:44 +0000 (-0600) Subject: scsi: ufs: ufshcd-pltfrm: Use of_property_present() X-Git-Tag: v6.12-rc1~124^2~19 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fd9cb9615fca4fa322a43eeecbd71d4de1ba146a;p=thirdparty%2Fkernel%2Flinux.git scsi: ufs: ufshcd-pltfrm: Use of_property_present() Use of_property_present() to test for property presence rather than of_find_property(). This is part of a larger effort to remove callers of of_find_property() and similar functions. of_find_property() leaks the DT struct property and data pointers which is a problem for dynamically allocated nodes which may be freed. Signed-off-by: Rob Herring (Arm) Link: https://lore.kernel.org/r/20240808170644.1436991-1-robh@kernel.org Reviewed-by: Bart Van Assche Signed-off-by: Martin K. Petersen --- diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c index a3e69ecafd275..2e1eb898a27c5 100644 --- a/drivers/ufs/host/ufshcd-pltfrm.c +++ b/drivers/ufs/host/ufshcd-pltfrm.c @@ -272,10 +272,10 @@ static int ufshcd_parse_operating_points(struct ufs_hba *hba) const char **clk_names; int cnt, i, ret; - if (!of_find_property(np, "operating-points-v2", NULL)) + if (!of_property_present(np, "operating-points-v2")) return 0; - if (of_find_property(np, "freq-table-hz", NULL)) { + if (of_property_present(np, "freq-table-hz")) { dev_err(dev, "%s: operating-points and freq-table-hz are incompatible\n", __func__); return -EINVAL;