From: Phil Sutter <phil@nwl.cc>
Date: Tue, 26 Aug 2025 10:57:37 +0000 (+0200)
Subject: trace: Fix for memleak in trace_alloc_list() error path
X-Git-Tag: v1.1.5~4
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fdbb0ec57b5c891c1de17f367b693ab787ea9c2d;p=thirdparty%2Fnftables.git

trace: Fix for memleak in trace_alloc_list() error path

The allocated 'list_expr' may leak.

Fixes: cfd768615235b ("src: add conntrack information to trace monitor mode")
Signed-off-by: Phil Sutter <phil@nwl.cc>
Reviewed-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
---

diff --git a/src/trace.c b/src/trace.c
index b2709510..47f4c215 100644
--- a/src/trace.c
+++ b/src/trace.c
@@ -258,6 +258,7 @@ static struct expr *trace_alloc_list(const struct datatype *dtype,
 	v = mpz_get_uint32(value);
 	if (v == 0) {
 		mpz_clear(value);
+		expr_free(list_expr);
 		return NULL;
 	}