From: Patrick Palka <ppalka@redhat.com>
Date: Thu, 30 Sep 2021 21:29:18 +0000 (-0400)
Subject: c++: argument order in a variadic type trait intrinsic
X-Git-Tag: basepoints/gcc-13~4317
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fdf8d5bc5b52bd733037dbeeff442c59f8aa765b;p=thirdparty%2Fgcc.git

c++: argument order in a variadic type trait intrinsic

When parsing a variadic type trait intrinsic, we build up the list of
trailing arguments in reverse, but we neglect to reverse the list to
the true order afterwards.  This causes us to confuse the meaning of
e.g. __is_xible(x, y, z) vs __is_xible(x, z, y).

Note that this bug doesn't affect the library traits because they pass a
pack expansion as the single trailing argument to __is_xible, which gets
expanded in the correct order by tsubst_tree_list.

gcc/cp/ChangeLog:

	* parser.c (cp_parser_trait_expr): Call nreverse on the reversed
	list of trailing arguments.

gcc/testsuite/ChangeLog:

	* g++.dg/ext/is_constructible6.C: New test.
---

diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c
index 8430445ef8c1..04f5a24cc03c 100644
--- a/gcc/cp/parser.c
+++ b/gcc/cp/parser.c
@@ -10832,6 +10832,7 @@ cp_parser_trait_expr (cp_parser* parser, enum rid keyword)
 	    return error_mark_node;
 	  type2 = tree_cons (NULL_TREE, elt, type2);
 	}
+      type2 = nreverse (type2);
     }
 
   location_t finish_loc = cp_lexer_peek_token (parser->lexer)->location;
diff --git a/gcc/testsuite/g++.dg/ext/is_constructible6.C b/gcc/testsuite/g++.dg/ext/is_constructible6.C
new file mode 100644
index 000000000000..7fce153fa759
--- /dev/null
+++ b/gcc/testsuite/g++.dg/ext/is_constructible6.C
@@ -0,0 +1,10 @@
+// Verify we respect the order of trailing arguments passed to
+// __is_constructible.
+
+struct A { };
+struct B { };
+struct C { C(A, B); };
+
+extern int n[true];
+extern int n[ __is_constructible(C, A, B)];
+extern int n[!__is_constructible(C, B, A)];