From: Björn Ardö Date: Thu, 5 Sep 2019 14:50:26 +0000 (+0200) Subject: i2c: slave-eeprom: Add comment about address handling X-Git-Tag: v5.4-rc1~51^2~4 X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fe050f99072d6b5175c35427a6f72846790441ec;p=thirdparty%2Fkernel%2Flinux.git i2c: slave-eeprom: Add comment about address handling The behaviour of the EEPROM in the case where we only send an 8bit address to a 16bit address EEPROM is not defined. Added comment about that the slave-eeprom might behave differently from how an actual device does (only one model measured). Reported-by: Wolfram Sang Signed-off-by: Björn Ardö Signed-off-by: Wolfram Sang --- diff --git a/drivers/i2c/i2c-slave-eeprom.c b/drivers/i2c/i2c-slave-eeprom.c index 773afaabfb61f..92ff9991bae81 100644 --- a/drivers/i2c/i2c-slave-eeprom.c +++ b/drivers/i2c/i2c-slave-eeprom.c @@ -11,6 +11,12 @@ * pointer, yet implementation is deferred until the need actually arises. */ +/* + * FIXME: What to do if only 8 bits of a 16 bit address are sent? + * The ST-M24C64 sends only 0xff then. Needs verification with other + * EEPROMs, though. We currently use the 8 bit as a valid address. + */ + #include #include #include