From: Michal Privoznik <mprivozn@redhat.com>
Date: Wed, 14 May 2025 13:48:40 +0000 (+0200)
Subject: virsh-pool.c: Fix return type of virshBuildPoolXML()
X-Git-Tag: v11.4.0-rc1~71
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fe1f94a034bcf16d7a50d0bde01e4a63362c95fe;p=thirdparty%2Flibvirt.git

virsh-pool.c: Fix return type of virshBuildPoolXML()

The virshBuildPoolXML() function is declared to return an int but
in fact its return type is a boolean. Even its both callers
(cmdPoolCreateAs() and cmdPoolDefineAs()) treat its retval as a
boolean. Switch the return type from integer to boolean.

Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
---

diff --git a/tools/virsh-pool.c b/tools/virsh-pool.c
index 33b130564e..089fde55e2 100644
--- a/tools/virsh-pool.c
+++ b/tools/virsh-pool.c
@@ -322,7 +322,7 @@ static const vshCmdOptDef opts_pool_define_as[] = {
     {.name = NULL}
 };
 
-static int
+static bool
 virshBuildPoolXML(vshControl *ctl,
                   const vshCmd *cmd,
                   const char **retname,