From: Vincent Bernat <vincent@bernat.im>
Date: Tue, 14 Jun 2016 09:45:02 +0000 (+0200)
Subject: lldpcli: add a test for return code
X-Git-Tag: 0.9.4~7
X-Git-Url: http://git.ipfire.org/?a=commitdiff_plain;h=fe64f8e56febd9a4ddbcfa42e346a58946639fe3;p=thirdparty%2Flldpd.git

lldpcli: add a test for return code
---

diff --git a/NEWS b/NEWS
index d8ffdf1b..12b430f4 100644
--- a/NEWS
+++ b/NEWS
@@ -5,6 +5,7 @@ lldpd (0.9.4)
   * Fix:
     + Fix setting of local value for port ID.
     + Fix compilation with BSD make.
+    + Ensure lldpcli returns an error code on invalid commands.
 
 lldpd (0.9.3)
   * Change:
diff --git a/tests/integration/test_lldpcli.py b/tests/integration/test_lldpcli.py
index 40a5e2c3..e224e448 100644
--- a/tests/integration/test_lldpcli.py
+++ b/tests/integration/test_lldpcli.py
@@ -283,3 +283,11 @@ def test_watch_json(lldpd1, lldpd, lldpcli, namespaces, links):
         del expected['lldp-deleted']['interface']['eth0']['age']
         del got['lldp-deleted']['interface']['eth0']['age']
         assert got == expected
+
+
+def test_return_code(lldpd1, lldpcli, namespaces):
+    with namespaces(1):
+        result = lldpcli("show", "neighbors")
+        assert result.returncode == 0
+        result = lldpcli("unknown", "command")
+        assert result.returncode == 1